-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operations remove 00 prefix from addresses which leads to crashes. #88
Comments
Can you tell what is the exact crash you see? It is a bit messy how the stack items are handled, there was an unfinished PR to sort that out (#37). |
The exact crash is: However, this is because at some point: EXTCODESIZE is called on |
@mhhf thanks! Will check it soon. |
when can we expect a version bump with this? |
After #84 is merged, hopefully all this week. |
@mhhf 2.0.1 is released 🎉 |
Should this fix be backported to 1.4? |
@ethernomad the 2.x release was made way too early and as such doesn't include many changes, but this also means moving to 2.x is very simple. The only change is to update the parameter passing to the VM constructor. |
Removing Travis Script
…exports k-bucket Update to v5.0.0 / esModuleInterop issue on client integration Fix
es6 round 1 - remove all vars and anon functions
Remove package.json `testling` property
I discovered this first in ethereumjs-vm 1.4 and could reproduce it in 2.0. Strangely this bug is system specific - it lead to a crash on Ubuntu but succeeded on OS X.
The error happens on a deployment of contract A which deploys another contract B. Code was compiled with solidity 0.4.3
At some Point the stack look like the following:
Here the operation MUL is performed which produces the stack:
Note that the new address misses its 00 prefix which later leads to an error.
The text was updated successfully, but these errors were encountered: