Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM: blake2f() precompile test hangs in Firefox #888

Closed
ryanio opened this issue Sep 22, 2020 · 3 comments
Closed

VM: blake2f() precompile test hangs in Firefox #888

ryanio opened this issue Sep 22, 2020 · 3 comments

Comments

@ryanio
Copy link
Contributor

ryanio commented Sep 22, 2020

In the karma test runner, the blake2f() function hangs in Firefox. The tests for F() below it work fine.

It is not immediately obvious to me what could be going wrong, especially because the precompile doesn't seem to rely on any special external crypto module or anything other than BN.

@evertonfraga
Copy link
Contributor

There are some pretty heavy Blake2f tests on our suite. I would first check if the same tests take long in Chrome, so we might want to adjust timeouts. It's not uncommon to see SpiderMonkey and Webkit performing differently under the same workload.

The other hypothesis, is that whenever a script takes too much resources from FF, the browser prompts the user if they want to stop or continue. I suspect the script execution is halted when the prompt appears. So we should either:

  • Find ways to "smoothen out" the way for FF to consume the script
  • Have a way to click on Continue in that prompt
  • Remove such tests from FF test suite (that would be unfortunate)

image

@holgerd77 holgerd77 changed the title blake2f() hangs in firefox VM: blake2f() precompile test hangs in Firefox Jan 13, 2022
@holgerd77
Copy link
Member

Someone should give this another test run on occasion.

@ryanio
Copy link
Contributor Author

ryanio commented Jan 13, 2022

yes this would be nice to see if it is still an issue, the test is skipped in Firefox with this code here:

if ((<any>globalThis).navigator?.userAgent.includes('Firefox')) {
// TODO: investigate why this test hangs in karma with firefox
return st.end()
}

@ryanio ryanio closed this as completed Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants