Test cleanup #437
Merged
Test cleanup #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1na
suggested changes
Feb 11, 2019
holgerd77
force-pushed
the
test-cleanup
branch
from
84a3f3b
to
b5e1b47
Compare
|
Just x-checked, the decrease in test coverage is from the So no actual coverage decrease and we can merge if everything else is ok. |
s1na
previously approved these changes
Feb 11, 2019
… due to DEPRECATION status)
…d with info msg pointing to more specific commands
holgerd77
force-pushed
the
test-cleanup
branch
from
b5e1b47
to
ed5041f
Compare
|
Already reviewed by @s1na, no production code touched, will merge. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This half-cleaned tests directory together with the outdated
runAll()test run function intester.jsis for quite some time some reoccurring source of confusion, latest during the work on #406.This PR does some cleanup here:
Separate
manualdirectory with the manualconstantionpleSstoreTesttest fileThis was once written by Vinay since the official test suite was not yet available. Tests still pass so would be a bit a pity to throw away. For the current situation this extra
manualcommand might be a bit too much. Reasoning would be nevertheless that there is then a place for similar tests in the future if necessary and things have some place then and there will be some higher chance that structure won't get bloated on stuff like this again.Update: Tests deleted after discussion.
Included
hooked.jsinto the API test suiteThese tests are still working. We can remove/adopt depending on what we do with this part of the API. For now the code is still there so this fits better in the API directory than having some (too prominent) separate place.
Integrated genesis hash test into the API test suite
This test was also floating around, not used for quite some time but still working. Have adopted and added to the API test suite. Genesis functionality of
StateManageris also not sure to be kept on final extracted version. Nevertheless for the moment it's still there and used.Replaced outdated runAll() test run code with info message
When
npm run testis run this is now showing a Command-not-used message. The code within the functionrunAll()is commented out. This was/is some major source of confusion for newcomers who tend to integrate their new tests there.Update: Function deleted after discussion.