Use the latest ethereumjs-util v6 in a new patch version of ethereumjs-blockchain #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version just replaces a tilde dependency with a caret one.
|
On second thought, I'd put this on hold until we re-examine the dependencies again. |
Update: @nebojsa94 already did this. This is in fact the only backport needed in ethereumjs to completely remove the dependence on node-gyp. |
|
It would be really beneficial for the project to release this soon, as it's blocking us. Once this is released, we need to make a few changes in projects outside of ethereumjs. |
evertonfraga
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @holgerd77,
I noticed that
ethereumjs-blockchainhad a tilde (~) dependency onethereumjs-util, which meant that it didn't get any benefit from the backports you released today.@evertonfraga already fixed this on
master, but that change will only land in@ethereumjs/blockchainand notethereumjs-blockchain, I created theblockchain/4.xthe branch here and backported the fix. The branch names follow the new conventions, as instructed by Everton.As this change is tiny, I also made the preparation of the new release here.
I think this should be the latest backport needed, but will rescan the dependency trees in search for more
~dependencies.