Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 Release planning #113

Closed
6 tasks done
holgerd77 opened this issue Apr 24, 2020 · 6 comments
Closed
6 tasks done

v1.0.0 Release planning #113

holgerd77 opened this issue Apr 24, 2020 · 6 comments

Comments

@holgerd77
Copy link
Member

holgerd77 commented Apr 24, 2020

The v1.0.0 version of the library will be released soon, this mainly builds upon the TypeScript rewrite done by @the-jackalope in #93.

Testing of the current master branch of the library is encouraged, please also note if you have suggestions for the release.

TODOs:

  • Integrate to-be-released ethereumjs-util v7.0.0 version mainly based on the work done here Update secp2561 ECDSA dependency to v4.0.0 ethereumjs-util#228 from @cgewecke
  • Wait for new hdkey dependency release (see comment below) to have a secp256k1 dependencies on v4, release is promised over on the library 😄
  • Remove ProviderEngine (needs discussion) Remove ProviderEngine #115
  • Update to patched ethereumjs-util v7.0.2 release (BN.js v5/v4 interoperability issue)
  • Optional: add CHANGELOG entry from v0.6.4 release (on its own v0.6.x branch)
  • Optional: give dependencies and devDependencies another look, some more explicit TypeScript version update (currently ^3.2.2)
@kumavis
Copy link
Member

kumavis commented Apr 25, 2020

@holgerd77 im interested in a 0.6.x patch with node v12 support
trying to identify a last-good commit for the 0.6.x version range
https://github.com/ethereumjs/ethereumjs-wallet/commits/master
can you help me identify the first breaking change commit?
changelog did not mention anything
https://github.com/ethereumjs/ethereumjs-wallet/blob/master/CHANGELOG.md

maybe 695da18?
so then changes since 0.6.3 up to that commit look like this:
e68a042...c04b80e#diff-c3b38b2d667a547e86b34134c77ff6f9
seems pretty safe. I'll cut a branch and cherry-pick the scrypt fix

@kumavis
Copy link
Member

kumavis commented Apr 25, 2020

@holgerd77 can you add ethereumjs committers team (or just me) to this repo? I'd like to be able to create and manage branches

@holgerd77
Copy link
Member Author

@kumavis have added you, please just don't do but communicate on what you are doing and planning frequently, thanks 🙂

@kumavis
Copy link
Member

kumavis commented Apr 27, 2020

here is my 0.6.x proposal #114

@holgerd77
Copy link
Member Author

hdkey dependency has an open PR cryptocoinjs/hdkey#32 for an secp2561 update to v4, might be worth the wait for a release to integrate a new version (have asked on GitHub).

@kumavis
Copy link
Member

kumavis commented Jan 18, 2021

v4 landed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants