Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dist import issue #65

Merged
merged 2 commits into from
Aug 8, 2018
Merged

Fix dist import issue #65

merged 2 commits into from
Aug 8, 2018

Conversation

holgerd77
Copy link
Member

Solution for #64

@@ -2,18 +2,19 @@
"name": "ethereumjs-wallet",
"version": "0.6.1",
"description": "Utilities for handling Ethereum keys",
"main": "dist/index.js",
Copy link
Contributor

@michaelsbradleyjr michaelsbradleyjr Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, you could keep this as dist/index.js, build from src/ into dist/, and place a script/s that doesn't get transpiled by babel at the top-level of the package, e.g. hdkey.js:

module.exports = require('./dist/hdkey.js');

For each module that people expect to be able to:

require('ethereumjs-wallet/<module>');

You would need a corresponding top-level script that's a one-liner re-export from the corresponding module in dist/.

@holgerd77
Copy link
Member Author

Have re-triggered the tests after an update to the coveralls command since this was still failing.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 88.462% when pulling b4c1c2e on fix-dist-import-issue into 71a51f1 on master.

Copy link
Member Author

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have looked at this again with a one-day-distance, will now merge since this is time-critical.

@holgerd77 holgerd77 merged commit efd2012 into master Aug 8, 2018
@holgerd77 holgerd77 deleted the fix-dist-import-issue branch August 8, 2018 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants