Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle bad urls #60

Merged
merged 2 commits into from
Mar 25, 2018
Merged

handle bad urls #60

merged 2 commits into from
Mar 25, 2018

Conversation

epheph
Copy link
Contributor

@epheph epheph commented Mar 23, 2018

Danz found this bug. When an error occurs that is not async, it is thrown and the whole thing breaks, even if valid transports could be found later.

@epheph epheph requested a review from tinybike March 23, 2018 17:22
@JohnDanz
Copy link
Collaborator

This looks like it should cover what i need 👍

tinybike
tinybike approved these changes Mar 25, 2018
View reviewed changes
Copy link
Member

@tinybike tinybike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tinybike tinybike merged commit 41cb80e into master Mar 25, 2018
@tinybike tinybike deleted the sbigelow/handle-bad-urls branch March 25, 2018 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinybike tinybike tinybike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@epheph @JohnDanz @tinybike