getCiphers() sometimes returns empty array #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getCiphers() sometimes returns empty array. Overriding with a default array in place.
anistark
changed the title
chikeichan
suggested changes
Apr 3, 2019
| return this.crypto.getCiphers().some(function (name) { return name === cipher; }); | ||
| var localCiphers = []; | ||
| if (this.crypto.getCiphers().length > 0) { | ||
| localCiphers = this.crypto.getCiphers() |
There was a problem hiding this comment.
Thanks for the PR @anistark !
I am not 100% comfortable with this approach as it simply ignore the empty results from getCiphers and override it with hardcoded values that we are not sure if they are supported, and introduce uncertainty for other users.
I am actually curious why getCiphers return an empty array. This seems to indicate a configuration problem. Could you share more details on the issues?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getCiphers() sometimes returns empty array. Overriding with a default array of all available algo in place.
Fix for issue #73