KZG Initialization Refactor #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have revised this slightly as follows:
|
g11tech
reviewed
Mar 14, 2024
g11tech
reviewed
Mar 14, 2024
g11tech
reviewed
Mar 14, 2024
g11tech
reviewed
Mar 14, 2024
src/index.ts
Outdated
| /** | ||
| * | ||
| * @param blob - a blob of data formatted as a Uint8Array of 4096 bytes | ||
| * @returns a KZG commitment corresponding to the input blob formatted as a 32 byte Uint8Array |
There was a problem hiding this comment.
Suggested change
| * @returns a KZG commitment corresponding to the input blob formatted as a 32 byte Uint8Array | |
| * @returns a KZG commitment corresponding to the input blob formatted as a 48 byte Uint8Array |
commitment is 48 bytes
Co-authored-by: g11tech <develop@g11tech.io>
g11tech
reviewed
Mar 14, 2024
src/index.ts
Outdated
| const blobToKzgCommitment = (blob: Uint8Array) => { | ||
| const blobHex = '0x' + blobToKzgCommitmentWasm(blob) | ||
| return hexToBytes(blobHex) | ||
| } | ||
|
|
||
| /** | ||
| * | ||
| * @param blob - a blob of data formatted as a Uint8Array of 4096 bytes |
There was a problem hiding this comment.
again correction needed for what is blob and size
g11tech
reviewed
Mar 14, 2024
src/index.ts
Outdated
| /** | ||
| * | ||
| * @param blob - a blob of data formatted as a Uint8Array of 4096 bytes | ||
| * @param commitment - a KZG commitment corresponding to a blob formatted as a 32 byte Uint8Array |
There was a problem hiding this comment.
Suggested change
| * @param commitment - a KZG commitment corresponding to a blob formatted as a 32 byte Uint8Array | |
| * @param commitment - a KZG commitment corresponding to a blob formatted as a 48 byte Uint8Array |
g11tech
reviewed
Mar 14, 2024
acolytec3
reviewed
Mar 14, 2024
g11tech
reviewed
Mar 14, 2024
acolytec3
reviewed
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor in preparation for a simplified KZG initialization on the EthereumJS side as discussed in the chat.