Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Upgrade from Travis to GH Actions #105

Merged
merged 3 commits into from
Mar 25, 2020
Merged

Upgrade from Travis to GH Actions #105

merged 3 commits into from
Mar 25, 2020

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented Mar 24, 2020 •
edited
Loading

This PR:

  1. Upgrades from Travis to GH Actions
    1. Adds node 13.x and removes 8.x support from test matrix
    2. Modernizes karma runner script
    3. Upgrades many old devDeps to improve dev experience
      1. Includes a few linting req syntax updates (probably from updated prettier dep)
      2. Removes .nycrc since it was creating a 0 coverage report with devDep version bumps.
        1. Default settings without config file seem to work perfectly for now, and can reintroduce @ethereumjs/config-nyc when fixed/updated upstream to work with latest nyc.

@ryanio ryanio force-pushed the ghActions branch 4 times, most recently from 3b33b4d to 91adf23 Compare March 24, 2020 23:42
@ryanio
Upgrade from Travis to GH Actions
0c915c1 
Upgrade karma test runner and devDeps
holgerd77
holgerd77 approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Ryan!

@holgerd77
Copy link
Member

Have updated the branch requirement settings, feel free to merge.

@ethereumjs ethereumjs deleted a comment from github-actions bot Mar 25, 2020
@ryanio ryanio merged commit b8c50ac into master Mar 25, 2020
@holgerd77 holgerd77 deleted the ghActions branch March 25, 2020 21:58
@ryanio ryanio mentioned this pull request Apr 17, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
PR state: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryanio @holgerd77