Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Fix test suite typos #114

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Fix test suite typos #114

merged 1 commit into from
Apr 27, 2020

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented Apr 27, 2020 •
edited
Loading

This PR:

  1. Fixes some test suite typos and let->const conversions found in EthWork's sync-related work - thanks guys!
  2. Removes unneeded uses of for await when iterators are sync.

@github-actions
Copy link

Coverage Status

Coverage remained the same at 94.992% when pulling 463485b on fixTypos into 7583aa9 on master.

holgerd77
holgerd77 approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanio ryanio merged commit 4990b32 into master Apr 27, 2020
@ryanio ryanio changed the title Fix typos Fix test suite typos May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
PR state: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryanio @holgerd77