Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Update readme references and examples #123

Merged
merged 5 commits into from Jun 22, 2020
Merged

Conversation

gabrocheleau
Copy link
Contributor

Added the Merkle Patricia Trees tutorial to the documentation, deleted the blog post with a 404 error and added a note for the blog post with outdated code.

@coveralls
Copy link

coveralls commented Jun 20, 2020

Coverage Status

Coverage remained the same at 94.712% when pulling c25a1e9 on gabrocheleau:master into 0d88016 on ethereumjs:master.

@gabrocheleau gabrocheleau marked this pull request as draft June 21, 2020 00:46
Copy link
Contributor

@evertonfraga evertonfraga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrocheleau I made a code suggestion, which I believe is the linter recommendation. Totally non ideal workflow, but I just want you to cross the finish line here.

You can also allow maintainers to make changes to your PR, so I could update your branch here directly.

I have just created an issue to track this bug: ethereumjs/ethereumjs-config#31

README.md Outdated Show resolved Hide resolved
@gabrocheleau gabrocheleau marked this pull request as ready for review June 22, 2020 13:04
Copy link
Contributor Author

@gabrocheleau gabrocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, thank you!

@evertonfraga evertonfraga self-requested a review June 22, 2020 14:05
README.md Outdated Show resolved Hide resolved
evertonfraga
evertonfraga previously approved these changes Jun 22, 2020
Co-authored-by: Ev <ev@ethereum.org>
Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanio ryanio changed the title Updated documentation Update readme references and examples Jun 22, 2020
@ryanio ryanio merged commit e2c3cd5 into ethereumjs:master Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants