-
Notifications
You must be signed in to change notification settings - Fork 90
Add benchmark.js and github-action-benchmark #130
Conversation
Sample results from run:
Some interesting results here:
|
i++ | ||
for (let i = 0; i < numOfIter; i++) { | ||
trie.checkpoint() | ||
await trie.put(keys[i], vals[i]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something else that'd be interesting to see is how checkpointing performance changes with the size of data to be commited. Here that size is one value (each value is committed separately).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something else that'd be interesting for finding the slowdown is a benchmark that does checkpoint
, inserts a bunch of stuff and then does revert
instead of commit
.
Comparing this bench on v4 and v3 should tell us whether the slowdown is happening in commit
(which is my suspicion) or not.
3947fdf
to
dcd4199
Compare
Rebased this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Coverage is not working right now. Will merge nevertheless since the library has to be switched to codecov anyhow to prepare for the monorepo transition.
This PR formats our existing benchmarks into a benchmark.js suite to ensure statistical significance of benchmark runs, and adds github-action-benchmark to compare and keep track of results.