This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
return stack for merkle proof #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. @kumavis any comments here? |
|
I think this PR is ok but better to make findPath public |
|
also i realized today that the diff in this PR while it looks like a non-breaking change, it would break if this were being used in an async.waterfall (different number of results -> different args to following method) |
|
closing because fixed by PR #22 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very easy way to enable the extraction of merkleproof data from this js module. Literally a one-line change. It does not break the existing API and only passes a reference (so no performance decreases either).
This data has everything needed to make the merkleproof (although it may be useful to reformat it into a standard like open-timestamp or chainpoint). I am creating a module to do the rest of the work and verify the proofs. Happy to merge it in this repo as well (if you want).