Safeguard against bug ganache-cli #417 #29
Conversation
|
Thanks for submitting this @rosario. Maybe I'm misunderstanding the change, but it looks like this masks the race condition rather than fixing its underlying cause. I think we want to fail fast, and fail loudly here, and fix the logic which causes the callback to |
| @@ -99,7 +99,7 @@ Trie.prototype.put = function (key, value, cb) { | |||
| if (self.root.toString('hex') !== ethUtil.SHA3_RLP.toString('hex')) { | |||
| // first try to find the give key or its nearst node | |||
| self.findPath(key, function (err, foundValue, keyRemainder, stack) { | |||
| if (err) { | |||
| if (err || !stack) { | |||
| return cb(err) | |||
There was a problem hiding this comment.
If stack is undefined, it's likely that err is also undefined or null. It seems this should still call cb with an error in this case.
There was a problem hiding this comment.
If I understood correctly there might be no error, but the stack would be undefined. Then updateNode would fail because there is no stack.
|
Very good point @benjamincburns. True, it's not fixing the race condition, but it would safeguard from calling functions on undefined values. I see now why it's ok to fail on those conditions |
|
Just merged #28 and also read through the various discussions on this on various places but got lost at some point. Are you guys still consider this as a PR to be considered? |
|
Any comments on this (see post above)? Otherwise I would close. |
The function
Trie.prototype.getRawcan only calldb.getwhen db is definedThe function
Trie.prototype.putwill call_updateNodewhen stack is defined