Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Use module.exports syntax in util files #90

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Jun 24, 2019

I remember facing some issues with the ES6 export syntax and it revolved around browsers. I suggest we use module.exports for now like the rest of the library. We can go back to the cleaner export syntax during the Typescript migration.

@holgerd77
Copy link
Member

Hmm, builds didn't run through, restarted both.

@s1na
Copy link
Contributor Author

s1na commented Jun 24, 2019

Seems like a problem with fetching nodejs to prepare the environment:

curl: (7) Failed to connect to nodejs.org port 443: Connection timed out

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 94.176% when pulling 247fb86 on utils-export-syntax into cf40000 on master.

@s1na
Copy link
Contributor Author

s1na commented Jun 24, 2019

Restarted the tasks (yet again) and now they pass

@s1na s1na merged commit 3f795c7 into master Jun 24, 2019
@s1na s1na deleted the utils-export-syntax branch June 24, 2019 13:28
@ryanio ryanio mentioned this pull request Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants