This repository has been archived by the owner on Jan 11, 2022. It is now read-only.
Handle Uint8Array inputs #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacogr
commented
Feb 7, 2018
jacogr
commented
- Handle Uint8Array inputs (equivalent to Buffer)
- Expand tests to test for Array & Buffer <-> Uint8Array equivalence
axic
reviewed
Feb 15, 2018
index.js
Outdated
| @@ -221,6 +221,8 @@ function toBuffer (v) { | |||
| } else if (v.toArray) { | |||
| // converts a BN to a Buffer | |||
| v = new Buffer(v.toArray()) | |||
| } else if (v instanceof Uint8Array) { | |||
| v = new Buffer(v) | |||
|
@jacogr thanks! Can you please rebase? And would be interested adding a similar change to ethereumjs-util? |
Closed
|
Hi @jacogr, would really like to close on this, do you think you could find some time to bring this over the finish-line (with a rebase and some changes regarding to the comments)? Would be cool! 😄 |
axic
approved these changes
Jul 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.