This repository has been archived by the owner on Jan 11, 2022. It is now read-only.
rewrote tests to typescript, improved typings #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
krzkaczor
commented
Nov 6, 2018
•
krzkaczor
commented
- rewrote tests in typescript
- fix some typing issues
- broke coverage computation (just for now)
holgerd77
reviewed
Nov 6, 2018
axic
reviewed
Nov 7, 2018
krzkaczor
force-pushed
the
kk/typescript-tests
branch
from
3d13ebe
to
664057b
Compare
holgerd77
approved these changes
Nov 8, 2018
| "lint": "standard", | ||
| "test": "istanbul test mocha -- --reporter spec", | ||
| "test": "mocha --reporter spec --require ts-node/register 'test/index.ts'", |
There was a problem hiding this comment.
Cannot make it work with 'test/index.ts' on windows cmd. I need to remove the quotes.
There was a problem hiding this comment.
sorry, i dont use windows these days i think it's 100% fine in this case to remove the quotes. (it's not when there is a glob pattern inside)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.