Add async initiation to JS glue code #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src.ts/tests/ffi.spec.ts
Outdated
| beforeAll(() => { | ||
| ffi = new VerkleFFI() | ||
| let ffi: Context; | ||
| let verkle; |
There was a problem hiding this comment.
Now that this initVerkleWasm() returns void, we can probably not assign it right?
There was a problem hiding this comment.
Good point. Have removed.
gabrocheleau
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates how the WASM is instantiated in
rust_verkle_wasm.jsto load the WASM as a base64 string and then instantiate it through an async initiation function which is then called by the consuming application.TODOs
initVerkleWasmfunction directly to the compiled JS glue code or do something more elegantinitVerkleWasm