-
Notifications
You must be signed in to change notification settings - Fork 168
cmd/geth: implement interval-based status logging #324
Commits on Jul 27, 2017
-
sketches for using API for logging... may be overkill
may be worth thinking about more flexible and beautiful ways to display information... 'monitor', 'attach', etc, along with termui, graphs... output can be 'machiney'-- line-by-line, or human-y -- pictures of buffalo and whatnot.
Configuration menu - View commit details
-
Copy full SHA for 8effd93 - Browse repository at this point
Copy the full SHA 8effd93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7abe6ca - Browse repository at this point
Copy the full SHA 7abe6caView commit details -
WIP: problem: should implement interval-based status logging
solution: use a go func connected to the node's Ethereum to grab and calculate relevant logs rel ethereumproject#127 rel ethereumproject#318 --- TODO: fix or remove: - downloading-from peers, eg 'this var/x/x peers' - shows mode 'FullSync' before downloader initializes, even if it will be 'FastSync'
Configuration menu - View commit details
-
Copy full SHA for a360b1c - Browse repository at this point
Copy the full SHA a360b1cView commit details -
problem: no reason to force RPC
solution: comment code and include small explanation
Configuration menu - View commit details
-
Copy full SHA for 8323600 - Browse repository at this point
Copy the full SHA 8323600View commit details -
problem: no reason to return eth from StartNode
solution: remove exploratory code that is not useless
Configuration menu - View commit details
-
Copy full SHA for 0fd6e5f - Browse repository at this point
Copy the full SHA 0fd6e5fView commit details
Commits on Jul 28, 2017
-
problem: warning log should use logger.Warn
solution: move to Warn from Error
Configuration menu - View commit details
-
Copy full SHA for 80f7222 - Browse repository at this point
Copy the full SHA 80f7222View commit details -
problem: log-pace flag usage antiquated
solution: update it and simplify
Configuration menu - View commit details
-
Copy full SHA for 6f530fe - Browse repository at this point
Copy the full SHA 6f530feView commit details -
problem: should polish log-pace function
solution: - remove dead code, old notes - remove units from --log-pace= argument, just use seconds as value (simpler is better) - if mining, show STATUS MINE with minerthreads and hashrate (TODO: more?) - gofmt Rel ethereumproject#127, ethereumproject#318
Configuration menu - View commit details
-
Copy full SHA for 0361214 - Browse repository at this point
Copy the full SHA 0361214View commit details
Commits on Jul 29, 2017
-
problem: minor variable renaming and comments
solution: improve legibility
Configuration menu - View commit details
-
Copy full SHA for cdafd37 - Browse repository at this point
Copy the full SHA cdafd37View commit details
Commits on Jul 30, 2017
-
problem: logging genesis account balances on Core log-level is too high
solution: relegate to debug
Configuration menu - View commit details
-
Copy full SHA for 5e5f52c - Browse repository at this point
Copy the full SHA 5e5f52cView commit details -
problem: can share interrupt chan
solution: share chan in main between shutdown and closing status log goroutine
Configuration menu - View commit details
-
Copy full SHA for 2990308 - Browse repository at this point
Copy the full SHA 2990308View commit details -
problem: logging to dir should also output to stderr
solution: implement and glog SetAlsoToStdErr exported function and use in case of --log-dir
Configuration menu - View commit details
-
Copy full SHA for 861d49b - Browse repository at this point
Copy the full SHA 861d49bView commit details -
problem: log io flush never called after interrupt
results in missing any logs after shutdown processes in FS logs solution: defer log Flush after shutdown services also decrease flushInterval from 30 -> 5 seconds (rate at which log buffer is written to FS)
Configuration menu - View commit details
-
Copy full SHA for 05dca17 - Browse repository at this point
Copy the full SHA 05dca17View commit details -
problem: rename '--log-pace' to '--log-status'
solution: rename flag and flagvar and status log function also adds logstatus flag to correct category for usage output
Configuration menu - View commit details
-
Copy full SHA for 027a8d0 - Browse repository at this point
Copy the full SHA 027a8d0View commit details -
problem: want --log-status to be extensible for other interfaces
solution: refactor to use '--log-status='sync=60'' syntax, which can eventually support other features besides 'sync', eg. mine, net, disk
Configuration menu - View commit details
-
Copy full SHA for a06f511 - Browse repository at this point
Copy the full SHA a06f511View commit details -
problem: (nonfunctional,refactor) should move cmd-oriented functions …
…to cmd.go solution: cut and paste and update imports
Configuration menu - View commit details
-
Copy full SHA for 492c7ca - Browse repository at this point
Copy the full SHA 492c7caView commit details -
Configuration menu - View commit details
-
Copy full SHA for a117f2f - Browse repository at this point
Copy the full SHA a117f2fView commit details
Commits on Jul 31, 2017
-
problem: rollback command logging confirmation should check fastblock
solution: error if neither fastblock nor fullblock match desired head number fixes ethereumproject#325
Configuration menu - View commit details
-
Copy full SHA for af4d7e4 - Browse repository at this point
Copy the full SHA af4d7e4View commit details -
problem: interrupt shutdown processes not consistent
solution: don't share os-interrupt channel as a global. Notify library documentation clearly says Notify events can be called multiple times and notification will be copied, so there's no harm in listening for the same event on mutliple channels. This pattern avoids a global and encourages per-feature handling of shutdown scenarios.
Configuration menu - View commit details
-
Copy full SHA for 5be13af - Browse repository at this point
Copy the full SHA 5be13afView commit details -
problem: (log syntax) log-status interval initial log still shows 'lo…
…g-pace' wording solution: fix
Configuration menu - View commit details
-
Copy full SHA for 82ea60b - Browse repository at this point
Copy the full SHA 82ea60bView commit details
Commits on Aug 16, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 4aed4f2 - Browse repository at this point
Copy the full SHA 4aed4f2View commit details