implement miner_setExtra API method #569

whilei · 2018-04-18T21:28:17Z

problem

Documented miner_setExtra method is missing.

https://github.com/ethereumproject/go-ethereum/wiki/JavaScript-Console#minersetextra

solution

Add method to *PrivateMinerAPI. Like other private miner methods, the setExtra function returns a boolean; true if value is successfully set, otherwise false.

example

> miner.setExtra("0xdeadbeef");
true

solution: add it

tzdybal

LGTM

whilei added 2 commits April 19, 2018 06:17

problem: miner_setExtra method missing

8bc274d

solution: add it

solution: fix missing import and add comment

f6142e0

whilei requested review from tzdybal and r8d8 April 18, 2018 21:28

tzdybal approved these changes Apr 18, 2018

View reviewed changes

whilei merged commit 4621800 into master Apr 18, 2018

whilei deleted the feax/miner-set-extra branch May 1, 2018 23:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement miner_setExtra API method #569

implement miner_setExtra API method #569

whilei commented Apr 18, 2018

tzdybal left a comment

implement miner_setExtra API method #569

implement miner_setExtra API method #569

Conversation

whilei commented Apr 18, 2018

problem

solution

example

tzdybal left a comment

Choose a reason for hiding this comment