This repository has been archived by the owner on Oct 4, 2019. It is now read-only.
relocate, refactor, and write a few bats tests #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solution: move all bats test files to tests/bats
solution: change path to be absolute from GOPATH
solution: use GOPATH as absolute ref to testdata instead
solution: write eth_ and personal_ bats integration tests yields: - although documented that apparent arbitrary data can be provided to be signed, in fact the data must be 0x-prefixed hex data (and not 'Schoolbus' as the documentation examples use. This behavior is consistent between Classic and Foundation go-ethereums
solution: refactor for reusability and shared logic - writes a few more personal_ api tests
solution: skip it instead, providing a message for why, too - also refactors the tests a little to use the BATS tmp dir
…ld pass solution: remove tests based on wrong documentation
solution: fix it. - trimmed extra whitespace in appveyor config, too
whilei
changed the title
whilei
changed the title
r8d8
approved these changes
May 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./cmd/geth/*.batsto./tests/bats/api_eth.batsandapi_personal.batswith the motivations:eth_signand it's counterpartpersonal_sign. https://github.com/ethereumproject/go-ethereum/wiki/JSON-RPC#eth_sign said that"Schoolbus"may be given as a data value to be signed, but in fact the value must be 0x-prefixed hex0xabcddata. In this case, the documentation was wrong, and I just fixed it.