Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new modifier to check if productId belongs to component #21

Merged
merged 7 commits into from
Aug 15, 2022
Merged

Add new modifier to check if productId belongs to component #21

merged 7 commits into from
Aug 15, 2022

Conversation

doerfli
Copy link
Contributor

@doerfli doerfli commented Aug 10, 2022 •
edited

No description provided.

@doerfli doerfli marked this pull request as draft August 10, 2022 14:27
matthiaszimmermann
matthiaszimmermann requested changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@matthiaszimmermann matthiaszimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • adapt require error message
  • do something with commented out line in constructor
  • remove onlyResponsibleProduct from all view funtions (data needs to be readably by anybody)

@doerfli doerfli force-pushed the bugfix/policy-checks-product branch 2 times, most recently from 10ad469 to 6d514c1 Compare August 12, 2022 09:54
@doerfli doerfli force-pushed the bugfix/policy-checks-product branch from 373ed32 to b1672ee Compare August 12, 2022 15:09
@doerfli doerfli marked this pull request as ready for review August 12, 2022 15:11
doerfli
doerfli commented Aug 15, 2022
View reviewed changes
contracts/examples/AyiiProduct.sol Outdated Show resolved Hide resolved
contracts/examples/AyiiProduct.sol Outdated Show resolved Hide resolved
contracts/examples/AyiiProduct.sol Outdated Show resolved Hide resolved
@doerfli doerfli force-pushed the bugfix/policy-checks-product branch from b1672ee to 2a53496 Compare August 15, 2022 12:53
@doerfli doerfli merged commit 3a5ade7 into master Aug 15, 2022
@doerfli doerfli deleted the bugfix/policy-checks-product branch August 15, 2022 13:50
doerfli added a commit that referenced this pull request Oct 20, 2022
@doerfli
Merge pull request #21 from etherisc/feature/npm-dist
b20b9a4 
Publish build artifacts to npm package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiaszimmermann matthiaszimmermann Awaiting requested review from matthiaszimmermann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doerfli @matthiaszimmermann