Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix role creation, add test cases #29

Merged
merged 3 commits into from
Aug 15, 2022
Merged

fix role creation, add test cases #29

merged 3 commits into from
Aug 15, 2022

Conversation

matthiaszimmermann
Copy link
Contributor

No description provided.


assert not instanceService.hasRole(poRole, productOwner)
assert not instanceService.hasRole(opRole, oracleProvider)
assert not instanceService.hasRole(rkRole, riskpoolKeeper)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add another round of grantRole to test if re-assignment is possible.

with brownie.reverts('ERROR:ACL-004:ROLE_UNKNOWN_OR_INVALID'):
instanceOperatorService.invalidateRole(NEW_ROLE, ioDict)

instanceOperatorService.invalidateRole(poRole, ioDict)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also make sure this can be reverted again ... in case someone uses this accidentally it can hurt.

@doerfli doerfli merged commit 439e99c into master Aug 15, 2022
@doerfli doerfli deleted the bug/fix-role-creation branch August 15, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants