Feature/treasury module validation #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
doerfli
commented
Sep 16, 2022
•
doerfli
commented
- setFee/CapitalSpecification should not overwrite createdAt attribute
- processCapital should check allwance,balance prior to attempt to call unifiedTransferFrom
- processCapital remove require for defined riskpoolWallet (as this is already covered with modifier riskpoolWalletDefinedForBundle)
- payout should require allowance/balance too
- withdrawal should require allowance/balance too
doerfli
force-pushed
the
feature/treasury_module_validation
branch
from
6fb2b5c
to
67c497b
Compare
doerfli
force-pushed
the
feature/treasury_module_validation
branch
from
5ef084c
to
bdaaa6f
Compare
doerfli
force-pushed
the
feature/treasury_module_validation
branch
from
b4e17b8
to
17beee0
Compare
matthiaszimmermann
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.