Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to stable addresses using CREATE2 #364

Open
doerfli opened this issue May 27, 2024 · 1 comment
Open

Deploy to stable addresses using CREATE2 #364

doerfli opened this issue May 27, 2024 · 1 comment
Assignees
Milestone

Comments

@doerfli
Copy link
Contributor

doerfli commented May 27, 2024

No description provided.

@doerfli doerfli added this to the GIF v3 Audit Ready milestone May 27, 2024
@doerfli doerfli self-assigned this May 27, 2024
doerfli added a commit that referenced this issue May 27, 2024
doerfli added a commit that referenced this issue May 27, 2024
doerfli added a commit that referenced this issue May 28, 2024
doerfli added a commit that referenced this issue May 28, 2024
doerfli added a commit that referenced this issue May 28, 2024
doerfli added a commit that referenced this issue Jun 17, 2024
doerfli added a commit that referenced this issue Jun 17, 2024
doerfli added a commit that referenced this issue Jun 17, 2024
doerfli added a commit that referenced this issue Jun 17, 2024
doerfli added a commit that referenced this issue Jun 17, 2024
doerfli added a commit that referenced this issue Jun 17, 2024
@doerfli
Copy link
Contributor Author

doerfli commented Jun 18, 2024

Current state of work

  • Using classic ethers deployments, CREATE2 strategies is not supported and would need manual implementation of the deployment which is too complex and error prone (such tasks should ideally be left to existing frameworks or tools).
  • Hardhat Ignition does support CREATE2 and seems to be the way forward for CREATE2 deployments with hardhat.
    But Hardhat ignition is not not fully stable yet (as of now we are using v0.15.5). After first tests, an issue was found that would lead to an exception during verification of the code (RangeError: Maximum call stack size exceeded during verification on deployment NomicFoundation/hardhat-ignition#770) and that was fixed. Now i've stumbled upon a bug where the gas price is not correct for L2s (hardhat ignition shows too high gas fees for L2s NomicFoundation/hardhat-ignition#724) which lead to a depletion of testing matics. Waiting for a response on the state of that bug.
  • Right now it seems that ignition is not as stable as we want it to be and we should therefor postpone the CREATE2 deployments for some time.
  • Pending task: confirm that ignition correctly verifies the code that was deployed (could not be confirmed so far due to the bugs mentioned above)
  • current implementation: the script ignition/modules/GifCore.ts contains a full deployment of the GifCore (like using GifDeployer). Deployment of services needs to be implemented once the decision to go forward with ignition has been done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants