Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global registry #372

Closed
wants to merge 9 commits into from
Closed

Global registry #372

wants to merge 9 commits into from

Conversation

rapidddenis
Copy link
Collaborator

@rapidddenis rapidddenis commented Jun 5, 2024

  • Introduces global registry contract deployable only on main net

  • Adds forge deployment with createX

  • only merge once the use of ignition for deployment has been decided and impleneted.

Copy link
Contributor

🚧 Require statements found

test/registry/RegistryTestBase.sol
\s+require(
  • info.objectType.toInt() == SERVICE().toInt(), "Test error: _afterServiceRegistration() called with non-service object"); Line: 466

@rapidddenis ⛔ Do not use require statements - please change it and use a custom error before merging this PR!

Copy link

gitguardian bot commented Jun 19, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11712615 Triggered Generic High Entropy Secret 2b0f23b test/base/GifTest.sol View secret
11712615 Triggered Generic High Entropy Secret 2b0f23b test/GifDeployer.t.sol View secret
11712615 Triggered Generic High Entropy Secret 2b0f23b test/registryService/RegistryServiceTestBase.sol View secret
11712616 Triggered Generic High Entropy Secret 2b0f23b test/registry/ServiceMockAuthorizationV3.sol View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@rapidddenis
Copy link
Collaborator Author

closed in favour of #456

@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant