-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global registry #372
Global registry #372
Conversation
408c2c5
to
652d04d
Compare
94ea242
to
04c52b0
Compare
🚧 Require statements foundtest/registry/RegistryTestBase.sol\s+require(
@rapidddenis ⛔ Do not use require statements - please change it and use a custom error before merging this PR! |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11712615 | Triggered | Generic High Entropy Secret | 2b0f23b | test/base/GifTest.sol | View secret |
11712615 | Triggered | Generic High Entropy Secret | 2b0f23b | test/GifDeployer.t.sol | View secret |
11712615 | Triggered | Generic High Entropy Secret | 2b0f23b | test/registryService/RegistryServiceTestBase.sol | View secret |
11712616 | Triggered | Generic High Entropy Secret | 2b0f23b | test/registry/ServiceMockAuthorizationV3.sol | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
closed in favour of #456 |
Introduces global registry contract deployable only on main net
Adds forge deployment with createX
only merge once the use of ignition for deployment has been decided and impleneted.