Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback provider priority documentation is inconsistent #1713

Closed
mrwillis opened this issue Jun 24, 2021 · 3 comments
Closed

Fallback provider priority documentation is inconsistent #1713

mrwillis opened this issue Jun 24, 2021 · 3 comments
Labels
documentation Documentation related issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@mrwillis
Copy link

Here https://github.com/ethers-io/ethers.js/blob/master/packages/providers/src.ts/fallback-provider.ts

it says that higher priorities are favoured first.

But here https://docs.ethers.io/v5/api/providers/other/#FallbackProvider it says lowered are favoured.

@mrwillis mrwillis added the documentation Documentation related issue. label Jun 24, 2021
@ricmoo
Copy link
Member

ricmoo commented Jun 24, 2021

Higher priority means lower number. :)

But I can clarify in the source.

@ricmoo
Copy link
Member

ricmoo commented Jun 24, 2021

Oh, I see the docs say “higher value”. Yes, that’s wrong. I’ll fix it. :)

@ricmoo ricmoo added the on-deck This Enhancement or Bug is currently being worked on. label Jun 24, 2021
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Jul 5, 2021
@ricmoo
Copy link
Member

ricmoo commented Jul 5, 2021

Fixed!

Thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

No branches or pull requests

2 participants