Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AlchemyProvider does not support EIP-1559, But Alchemy node can support now. #1893

Closed
lily-57blocks opened this issue Aug 20, 2021 · 4 comments
Closed

AlchemyProvider does not support EIP-1559, But Alchemy node can support now. #1893

lily-57blocks opened this issue Aug 20, 2021 · 4 comments
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@lily-57blocks
Copy link

lily-57blocks commented Aug 20, 2021 •
edited

Try to use gas estimate that EIP-1559 in AlchemyProvider, but throw errer: AlchemyProvider does not currently support EIP-1559.
@lily-57blocks lily-57blocks added the investigate Under investigation and may be a bug. label Aug 20, 2021
@ricmoo
Copy link
Member

ricmoo commented Aug 23, 2021

This should be fixed now. It was an issue on Alchemy's side. See here for more information.

Closing this as a duplicate; if you are still experiencing this, please update the other issue. :)

Thanks! :)

@ricmoo ricmoo closed this as completed Aug 23, 2021
@ricmoo ricmoo added duplicate Duplicate of another issue. and removed investigate Under investigation and may be a bug. labels Aug 23, 2021
@ricmoo
Copy link
Member

ricmoo commented Aug 24, 2021

I see a reply in my inbox, but no update here. Not sure why. But I see what you mean!

The code in Alchemy did have an extra condition present, I forgot to remove. Alchemy early on supported EIP-1559 for transactions, but not for estimateGas, so I added that nugget of code.

Re-opening, and I will fix it.

@ricmoo ricmoo reopened this Aug 24, 2021
@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. and removed duplicate Duplicate of another issue. labels Aug 24, 2021
ricmoo added a commit that referenced this issue Aug 24, 2021
@ricmoo
Removed temporary code for better errors needed until Alchemy added E…
accb852 
…IP-1559 support (#1893).
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Aug 27, 2021
@ricmoo
Copy link
Member

ricmoo commented Aug 27, 2021

This has been fixed in 5.4.6. Let me know if there are any problems.

Thanks! :)

@ricmoo
Copy link
Member

ricmoo commented Aug 31, 2021

I think this has been fixed, so I'm closing it now. Feel free to re-open though if not though.

Thanks! :)

@ricmoo ricmoo closed this as completed Aug 31, 2021
This was referenced Sep 18, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricmoo @lily-57blocks