Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Provider to acces headers #2644

Closed
RobbingBlocks opened this issue Feb 3, 2022 · 4 comments
Closed

Allow Provider to acces headers #2644

RobbingBlocks opened this issue Feb 3, 2022 · 4 comments
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@RobbingBlocks
Copy link

defineReadOnly(this, "_websocket", new WebSocket(this.connection.url));

Some endpoints need headers for SigV4 signing. Can we allow the WebSocket to accept headers?

@ricmoo
Copy link
Member

ricmoo commented Feb 3, 2022

This is coming in the next minor version, which will allow a raw WebSocket to be passed into WebSocketProvider. :)

@ricmoo ricmoo added enhancement New feature or improvement. minor-bump Planned for the next minor version bump. on-deck This Enhancement or Bug is currently being worked on. labels Feb 3, 2022
@RobbingBlocks
Copy link
Author

Nice! How do I know when it's available?

@ricmoo
Copy link
Member

ricmoo commented Mar 10, 2022

This should now be available in v5.6. You can now pass a WebSocket directly into a WebSocketProvider, so you can configure it however you wish.

Try it out and let me know if it works for you. :)

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. minor-bump Planned for the next minor version bump. labels Mar 10, 2022
@ricmoo
Copy link
Member

ricmoo commented Mar 17, 2022

This was added, so I'll close it. Please re-open or create a new issue if there are any problems.

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

No branches or pull requests

2 participants