Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UnhandledPromiseRejectionWarning in contracts with bad name resolution #2737

Closed
ricmoo opened this issue Feb 24, 2022 · 2 comments
Closed

Fix UnhandledPromiseRejectionWarning in contracts with bad name resolution #2737

ricmoo opened this issue Feb 24, 2022 · 2 comments
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@ricmoo
Copy link
Member

ricmoo commented Feb 24, 2022

Reported in Discord by NguyenTran.

When using contract.connect(undefined), the flow triggers a Promise which may never be checked, which may throw.

This causes node.js to raise a UnhandledPromiseRejectionWarning, which may abort the node process.

I've already added a local fix, which will be published with the v5.6 branch and this issue is mainly for tracking purposes.
@ricmoo ricmoo added investigate Under investigation and may be a bug. bug Verified to be an issue. on-deck This Enhancement or Bug is currently being worked on. and removed investigate Under investigation and may be a bug. labels Feb 24, 2022
ricmoo added a commit that referenced this issue Mar 2, 2022
@ricmoo
Fix contracts when name resolution fails without any checks (#2737).
c2a6a01
@ricmoo
Copy link
Member Author

ricmoo commented Mar 10, 2022

This should be fixed in v5.6.

Please try it out and let me know if you have any issues. :)

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Mar 10, 2022
@ricmoo
Copy link
Member Author

ricmoo commented Mar 17, 2022

This was fixes, so I'll close it. Please re-open if there are any problems.

Thanks! :)

@ricmoo ricmoo closed this as completed Mar 17, 2022
This was referenced Apr 12, 2022
Open
Open
Open
Open
Open
Open
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
@ricmoo @Woodpile37
Fix contracts when name resolution fails without any checks (ethers-i…
fb804e7 
…o#2737).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricmoo