Passing a number where a contract expects an address produces a bad error message

[ldct]

     TypeError: name.toLowerCase is not a function
      at Object.namehash (/Users/xuanji/gits/cf/monorepo/node_modules/ethers/utils/hash.js:11:17)
      at Web3Provider.BaseProvider.resolveName (/Users/xuanji/gits/cf/monorepo/node_modules/ethers/providers/base-provider.js:1015:31)
      at resolveAddresses (/Users/xuanji/gits/cf/monorepo/node_modules/ethers/contract.js:83:25)
      at /Users/xuanji/gits/cf/monorepo/node_modules/ethers/contract.js:78:29
      at Array.forEach (<anonymous>)
      at resolveAddresses (/Users/xuanji/gits/cf/monorepo/node_modules/ethers/contract.js:70:19)
      at Object.delegateTarget (/Users/xuanji/gits/cf/monorepo/node_modules/ethers/contract.js:142:16)

[ricmoo]

Can you provide some context? What code is causing this.

[ldct]

function delegateTarget(
  address registryAddr
)
  public
{
  require(registryAddr == address(0));
}

javascript:

await contract.functions.delegateTarget(0);

where contract: ethers.Contract

[ricmoo]

The number 0 is not a valid Ethereum address; addresses must be a valid string (either a hex string or IBAN). You likely want something more like:

await contract.functions.delegateTarget(ethers.constants.AddressZero);

[ricmoo]

Oh. You just want a better error message?

[ldct]

Yeap

…

On Wed, Dec 5, 2018, 2:22 PM Richard Moore ***@***.*** wrote: Oh. You just want a better error message? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#364 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAH9OqFGGtu2Uek4B7UgwlR3vWfmPhtZks5u12WkgaJpZM4ZCEVQ> .

[ricmoo]

The error is now "invalid address" :)

Thanks! :)