Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface.parseTransaction() returns signature as name #370

Closed
metsawyr opened this issue Dec 8, 2018 · 2 comments
Closed

Interface.parseTransaction() returns signature as name #370

metsawyr opened this issue Dec 8, 2018 · 2 comments
Assignees
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@metsawyr
Copy link

metsawyr commented Dec 8, 2018

Interface.prototype.parseTransaction() method returns same name as signature in _TransactionDescription object from transaction that called solidity function myFunction(id: uint256).

Actual result:
name property equals myFunction(uint256).
signature property equals myFunction(uint256)

Expected result:
name property equals myFunction.
signature property equals myFunction(uint256)

@ricmoo ricmoo self-assigned this Dec 8, 2018
@ricmoo ricmoo added investigate Under investigation and may be a bug. bug Verified to be an issue. on-deck This Enhancement or Bug is currently being worked on. and removed investigate Under investigation and may be a bug. labels Dec 8, 2018
@ricmoo
Copy link
Member

ricmoo commented Dec 8, 2018

You are right!

I've reproduced this and added test cases for the future. Once the tests are complete, I will publish to npm.

Thanks! :)

@ricmoo
Copy link
Member

ricmoo commented Dec 9, 2018

Published in 4.0.18. Let me know if you still have any problems, and feel free to re-open this issue.

Thanks! :)

@ricmoo ricmoo closed this as completed Dec 9, 2018
@ricmoo ricmoo removed the on-deck This Enhancement or Bug is currently being worked on. label Dec 10, 2018
@ricmoo ricmoo added the fixed/complete This Bug is fixed or Enhancement is complete and published. label Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

No branches or pull requests

2 participants