Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: invalid address (arg="address", value=undefined, version=4.0.22) #400

Closed
ochikov opened this Issue Jan 24, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@ochikov
Copy link

ochikov commented Jan 24, 2019

Hello,
when trying to deploy a contract in locally run ganache network, I am getting the following error:

{ Error: invalid address (arg="address", value=undefined, version=4.0.22)
    at Object.throwError (/Users/ognyanchikov/Etherlime/etherlime/node_modules/ethers/errors.js:76:17)
    at Object.getAddress [as from] (/Users/ognyanchikov/Etherlime/etherlime/node_modules/ethers/utils/address.js:75:16)
    at check (/Users/ognyanchikov/Etherlime/etherlime/node_modules/ethers/providers/base-provider.js:41:36)
    at checkTransactionReceipt (/Users/ognyanchikov/Etherlime/etherlime/node_modules/ethers/providers/base-provider.js:301:18)
    at /Users/ognyanchikov/Etherlime/etherlime/node_modules/ethers/providers/base-provider.js:927:39
    at <anonymous>
    at process._tickDomainCallback (internal/process/next_tick.js:228:7)
  reason: 'invalid address',
  code: 'INVALID_ARGUMENT',
  arg: 'address',
  value: undefined,
  checkKey: 'from',
  checkValue: undefined } 

I tried with version 4.0.21 and this error is not present.
Thank you.

@ricmoo

This comment has been minimized.

Copy link
Member

ricmoo commented Jan 24, 2019

this may be related to the change I made yesterday which expects a from in transaction receipts. It looks like Ganache may not properly add it, so I’ll make it an optional property today.

@ricmoo ricmoo self-assigned this Jan 24, 2019

@ricmoo

This comment has been minimized.

Copy link
Member

ricmoo commented Jan 24, 2019

This was caused by the fix to #398.

I've died it locally and will publish once the regression tests have passed.

We are working on a new suite of tests which will test providers against Ganache, parity, Geth, et al, so in the future these little incompatibilities between clients will be caught.

Sorry for the inconvenience.

ricmoo added a commit that referenced this issue Jan 24, 2019

@ricmoo

This comment has been minimized.

Copy link
Member

ricmoo commented Jan 24, 2019

This should be fixed in 4.0.23; can you try it out and let me know if you still have any problems?

Thanks! :)

@ochikov ochikov closed this Jan 25, 2019

@ochikov ochikov reopened this Jan 25, 2019

@ochikov

This comment has been minimized.

Copy link
Author

ochikov commented Jan 25, 2019

Yes, it is fixed in version 4.0.23. We can close the issue. Thank you.

@ricmoo

This comment has been minimized.

Copy link
Member

ricmoo commented Jan 25, 2019

Awesome!

Thanks! :)

@ricmoo ricmoo closed this Jan 25, 2019

@ricmoo ricmoo removed the on-deck label Feb 11, 2019

andrewgordstewart added a commit to magmo/force-move-games that referenced this issue Feb 21, 2019

lalexgap added a commit to magmo/force-move-games that referenced this issue Feb 26, 2019

andrewgordstewart added a commit to magmo/force-move-games that referenced this issue Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.