Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FallbackProvider unref timers too aggressively #815

Closed
ricmoo opened this issue May 3, 2020 · 1 comment
Closed

FallbackProvider unref timers too aggressively #815

ricmoo opened this issue May 3, 2020 · 1 comment
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@ricmoo
Copy link
Member

ricmoo commented May 3, 2020

The FallbackProivder unrefs timers (in node.js) to prevent slower responses from preventing exit. This can cause pre-mature exit.

The timers need to be more carefully managed, by unref-ing any timer still in fight once a result is available, but no sooner.
@ricmoo ricmoo added bug Verified to be an issue. next version (v5) on-deck This Enhancement or Bug is currently being worked on. labels May 3, 2020
ricmoo added a commit that referenced this issue May 3, 2020
@ricmoo
Manage FallbackProvider stalling without unref (#815).
7b1a7c7
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels May 7, 2020
@ricmoo
Copy link
Member Author

ricmoo commented May 7, 2020

This was included in 5.0.0-beta.185.

@ricmoo ricmoo closed this as completed May 7, 2020
michaeltout pushed a commit to michaeltout/ethers.js that referenced this issue Aug 23, 2020
@ricmoo
Manage FallbackProvider stalling without unref (ethers-io#815).
7a794d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricmoo