Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade uuid to 8.2.0 (dependency of json-wallets) #966

Closed
pnlp-dev opened this issue Jul 19, 2020 · 4 comments
Closed

Upgrade uuid to 8.2.0 (dependency of json-wallets) #966

pnlp-dev opened this issue Jul 19, 2020 · 4 comments
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@pnlp-dev
Copy link

There is a more recent version of uuid that contains an important fix that removes references to global (which is a node-specific reference and is not available in the browser): uuidjs/uuid@0ea33e6

ethers/json-wallets should upgrade to at least this version.

The latest version of uuid on npm at the time of ticket creation is this: 8.2.0

@ricmoo
Copy link
Member

ricmoo commented Jul 20, 2020

I've actually been meaning to remove that dependency entirely, as such a tiny amount of RFC-4122 is actually used.

I'll get this change made this week.

@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. labels Jul 20, 2020
@ricmoo
Copy link
Member

ricmoo commented Jul 20, 2020

I had a few minutes and this seemed like a simple task to do while some things were running. :)

I've added this in v5.0.7. Let me know if there are any issues.

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Jul 20, 2020
@pnlp-dev
Copy link
Author

Awesome, thank you!

@ricmoo
Copy link
Member

ricmoo commented Jul 22, 2020

No problem.

Thanks for the reminder! :)

@ricmoo ricmoo closed this as completed Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

No branches or pull requests

2 participants