Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API provider documentation #2242

Closed
wants to merge 1 commit into from
Closed

Conversation

emnul
Copy link

@emnul emnul commented Oct 28, 2021

Updated the provider documentation to close #2222

@imaksp
Copy link

imaksp commented Dec 7, 2021

Hi, new ones like arbitrum, optimism etc are now added:
https://github.com/ethers-io/ethers.js/blob/master/packages/providers/src.ts/infura-provider.ts

I think its better to use same name as Infura like (optimism-mainnet, polygon-mainnet) OR take url & project id as input, it will remove need of this switch case, so it will support all new additions automatically but it would be Breaking change, but can be included in v6, what do you think @ricmoo ?

& in ethers' docs this Infura's docs link can be added:
https://infura.io/docs/ethereum#section/Choose-a-Network

@ricmoo
Copy link
Member

ricmoo commented Feb 3, 2022

I want to make sure we use the same names for all these networks across all providers, so there may be small differences between a given Backend's name and the name used by ethers. In v6, the Network class helps isolate this a bit more, so hopefully it will be less of an issue then. I'm still waiting on getting some of the networks vetted for the ethers default keys, which will work with the getDefaultProvider, which is why it is more important that each Provider uses the same name.

@ricmoo
Copy link
Member

ricmoo commented Feb 3, 2022

Otherwise, merged though.

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example for connecting to Polygon Mumbai test network please? ☺️
3 participants