-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refresh after chequebook withdraw deposit #576
Conversation
🐝 PR preview in SwarmPreview URL: https://bah5acgzacilq553e4wci46qmcnc37bqs73mkrc7bcixzbopg6x5kbanurpaa.bzz.link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, but...
src/containers/DepositModal.tsx
Outdated
const transactionHash = await beeDebugApi.depositTokens(amount.toString()).catch((error: Error) => { | ||
throw error | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ehm why the catch()
? With throw
inside it? 🤨
const transactionHash = await beeDebugApi.depositTokens(amount.toString()).catch((error: Error) => { | |
throw error | |
}) | |
const transactionHash = await beeDebugApi.depositTokens(amount.toString()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To convert unhandled rejection to a sync error, but it turned out not to be necessary. Removing.
No description provided.