Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add loading state to info page #584

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Conversation

Cafe137
Copy link
Collaborator

@Cafe137 Cafe137 commented Nov 10, 2022

This PR extracts the status cards on info/home page.

Add readiness to provider.

And implements a loading state when node is healthy but not ready.

Only one card is shown during that time period.

@bee-worker
Copy link
Collaborator

bee-worker commented Nov 10, 2022

🐝 PR preview in Swarm

Preview URL: https://bah5acgzaiciljhlyr62u63puuseoidzjsuqqe6lclcx7tbyxtvdszyekaofq.bzz.link
Swarm Hash: 4090b49d788fb54f6df4a488e40f29952102796258aff987179d472ce08a038b
Commit Hash: 6ed0b38
Commit Message: refactor: use bee-js for readiness check

@Cafe137 Cafe137 marked this pull request as ready for review November 14, 2022 10:16
@Cafe137
Copy link
Collaborator Author

Cafe137 commented Nov 14, 2022

Not connected:

Screenshot 2022-11-14 at 12 39 24

Healthy but not ready:

Screenshot 2022-11-14 at 12 39 47

Ready:

Screenshot 2022-11-14 at 12 39 58

Copy link
Contributor

@AuHau AuHau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM! I have tested it out and it worked nicely!

My only question is if we should also not tackle with this PR (or maybe follow up one?) the fact that during startup in the sidebar, there is displayed "Node error" with red dot, which maybe should also be changed to something like "Node starting" and something like blue dot?

@Cafe137
Copy link
Collaborator Author

Cafe137 commented Nov 14, 2022

@AuHau Thanks for giving this a test ride 🙂

Absolutely, this PR was mostly for fixing the annoying and misleading chequebook status on homepage, but as a next step I'd like to polish the dashboard in a new PR and that would include extracting and implementing this status to other places. Will track it here and I'll merge this: #585

@Cafe137 Cafe137 merged commit 0246904 into master Nov 14, 2022
@Cafe137 Cafe137 deleted the fix/info-page-readiness branch November 14, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chequebook reports "not deployed" on home page during Bee HTTP API startup period
3 participants