refactor!: use bzz endpoint for file and dirs #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuHau
force-pushed
the
refactor/adjust-to-new-bee-api
branch
2 times, most recently
from
396bdfc
to
20cf6d5
Compare
AuHau
force-pushed
the
refactor/adjust-to-new-bee-api
branch
from
20cf6d5
to
695e865
Compare
Cafe137
reviewed
May 4, 2021
Cafe137
reviewed
May 4, 2021
agazso
reviewed
May 4, 2021
src/modules/bzz.ts
Outdated
| headers: { | ||
| ...extractFileUploadHeaders(options), | ||
| }, | ||
| params, |
There was a problem hiding this comment.
It's possible to rewrite this as
params: {
name,
},Then the params declaration above with the if (name) { ... } is not necessary.
Closed
agazso
reviewed
May 5, 2021
| name?: string, | ||
| options?: FileUploadOptions, | ||
| ): Promise<Reference> { | ||
| if (!url) { |
There was a problem hiding this comment.
This check is not strictly necessary because uploadFile is not exposed to the public API, therefore it's always called with the inputs already validated.
We also doesn't check the inputs or the url in other functions. If you want stronger guarantees it's possible to create a BeeURL type which is already validated and have the type system enforce its validity.
AuHau
added a commit
that referenced
this pull request
May 6, 2021
AuHau
added a commit
that referenced
this pull request
May 18, 2021
AuHau
added a commit
that referenced
this pull request
May 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts the upcoming changes to bee (see ethersphere/bee#1501). Also tackles partially the #265. It won't be merged atm. but it is ready for review.
Current limitation of this PR:
isSupportedVersionfails because we are running tests against latest master.browsershould pin and unpin collectiontest is disabled as it now newly usesSwarm-Collectionheader and because of that it runs into bee bug CORS Preflight request: return supported headers bee#1376Breaking changes:
download*FromCollectionrecursiveflag fromuploadFilesFromDirectory