fix: if there are no postage stamps the getAllPostageBatch should return [] #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechsimetka
changed the title
|
Thanks! Good catch! I fixed this for the pinning endpoint but forgot that this will be the case here as well. I think that actually, the approach here is to check if null is returned and then return empty array instead. https://github.com/ethersphere/bee-js/blob/bee-0.6.0/src/modules/pinning.ts#L73 |
|
Haha, yeah, you were faster. |
|
This should actually be even simpler because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No idea how to test this since the tests are in random order and I can not guarantee there is no postage stamp, right?