Skip to content

Commit

Permalink
feat: track errors
Browse files Browse the repository at this point in the history
  • Loading branch information
ralph-pichler committed Jun 7, 2021
1 parent ba85880 commit bde065a
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 4 deletions.
22 changes: 18 additions & 4 deletions pkg/settlement/pseudosettle/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@ type metrics struct {
// all metrics fields must be exported
// to be able to return them by Metrics()
// using reflection
TotalReceivedPseudoSettlements prometheus.Counter
TotalSentPseudoSettlements prometheus.Counter
ReceivedPseudoSettlements prometheus.Counter
SentPseudoSettlements prometheus.Counter
TotalReceivedPseudoSettlements prometheus.Counter
TotalSentPseudoSettlements prometheus.Counter
ReceivedPseudoSettlements prometheus.Counter
SentPseudoSettlements prometheus.Counter
ReceivedPseudoSettlementsErrors prometheus.Counter
SentPseudoSettlementsErrors prometheus.Counter
}

func newMetrics() metrics {
Expand Down Expand Up @@ -47,6 +49,18 @@ func newMetrics() metrics {
Name: "sent_pseudosettlements",
Help: "Number of time settlements sent to peers",
}),
ReceivedPseudoSettlementsErrors: prometheus.NewCounter(prometheus.CounterOpts{
Namespace: m.Namespace,
Subsystem: subsystem,
Name: "received_pseudosettlements_errors",
Help: "Errors of time settlements received from peers",
}),
SentPseudoSettlementsErrors: prometheus.NewCounter(prometheus.CounterOpts{
Namespace: m.Namespace,
Subsystem: subsystem,
Name: "sent_pseudosettlements_errorss",
Help: "Errors of time settlements sent to peers",
}),
}
}

Expand Down
7 changes: 7 additions & 0 deletions pkg/settlement/pseudosettle/pseudosettle.go
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ func (s *Service) handler(ctx context.Context, p p2p.Peer, stream p2p.Stream) (e
defer func() {
if err != nil {
_ = stream.Reset()
s.metrics.ReceivedPseudoSettlementsErrors.Inc()
} else {
go stream.FullClose()
}
Expand Down Expand Up @@ -241,6 +242,12 @@ func (s *Service) Pay(ctx context.Context, peer swarm.Address, amount *big.Int,

var err error

defer func() {
if err != nil {
s.metrics.ReceivedPseudoSettlementsErrors.Inc()
}
}()

var lastTime lastPayment
err = s.store.Get(totalKey(peer, SettlementSentPrefix), &lastTime)
if err != nil {
Expand Down

0 comments on commit bde065a

Please sign in to comment.