feat: add various transaction endpoint and track pending transactions #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralph-pichler
force-pushed
the
tx_watch_by_nonce
branch
from
a33d1b7
to
5936d42
Compare
ralph-pichler
force-pushed
the
tx_api
branch
2 times, most recently
from
198c100
to
9066f5e
Compare
ralph-pichler
force-pushed
the
tx_watch_by_nonce
branch
2 times, most recently
from
144d721
to
4d5efee
Compare
ralph-pichler
force-pushed
the
tx_api
branch
2 times, most recently
from
02bd0b5
to
b415f42
Compare
ralph-pichler
force-pushed
the
tx_api
branch
3 times, most recently
from
b20305d
to
d177b5c
Compare
ralph-pichler
force-pushed
the
tx_api
branch
2 times, most recently
from
2ab0cb7
to
b1ae8fa
Compare
ralph-pichler
changed the title
|
Thank you for this PR. Our users will love this one :) |
zelig
approved these changes
Jun 15, 2021
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ralph-pichler)
metacertain
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few transaction related endpoints useful for debugging and fixing potential transaction-related issues.
It builds on top of the functionality introduced in #1465 and adds the following debugapi endpoints:
GET /transactionsto get a list of transactions sent by bee which are neither confirmed nor provably cancelled (in other words "pending")GET /transactions/{hash}to get details for a particular transaction (wether pending or not)POST /transactions/{hash}to resend a transaction to the ethereum backend. This is useful if a pending transaction disappears from the eth network for some reason.To enable querying which transactions are actually pending, all sent transactions are monitored by default (using the machinery introduced in #1465). To make the output of the endpoints more useful some context has been added to the
TxRequestdefinition.This change is