-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lightnode,libp2p): add prometheus metrics #1979
Conversation
2671613
to
eb7f40e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aloknerurkar, @anatollupacescu, and @mrekucci)
pkg/topology/lightnode/container.go, line 63 at r1 (raw file):
func (c *Container) KickOut(_ p2p.Peer) { c.metrics.TotalKickedPeers.Inc()
this metric can be inside libp2p
, it doesn't really matter to have it on the light node container. also, if the peer info is not used, why do we need it?
eb7f40e
to
2a8c128
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 5 files reviewed, 1 unresolved discussion (waiting on @acud, @aloknerurkar, and @anatollupacescu)
pkg/topology/lightnode/container.go, line 63 at r1 (raw file):
Previously, acud (acud) wrote…
this metric can be inside
libp2p
, it doesn't really matter to have it on the light node container. also, if the peer info is not used, why do we need it?
Done.
2a8c128
to
7a87cd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aloknerurkar)
Adds the following metrics:
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)