Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't log checking pending transactions as errors #2046

Merged
merged 1 commit into from
Jun 10, 2021
Merged

fix: don't log checking pending transactions as errors #2046

merged 1 commit into from
Jun 10, 2021

Conversation

ralph-pichler
Copy link
Member

@ralph-pichler ralph-pichler commented Jun 10, 2021 •
edited by acud
Loading

  • don't log checking pending transactions as errors. this can happen frequently with load-balanced eth backends where later requests hit a node which has not seen the same block yet.
  • don't update lastBlock so we retry on the next iteration

This change is Reviewable

@ralph-pichler ralph-pichler added the ready for review The PR is ready to be reviewed label Jun 10, 2021
@ralph-pichler ralph-pichler self-assigned this Jun 10, 2021
mrekucci
mrekucci approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@mrekucci mrekucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ralph-pichler)

@ralph-pichler ralph-pichler merged commit 6d2b270 into master Jun 10, 2021
@ralph-pichler ralph-pichler deleted the tx_log branch June 10, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrekucci mrekucci mrekucci approved these changes

@acud acud acud approved these changes

@istae istae istae approved these changes

Assignees

@ralph-pichler ralph-pichler

Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ralph-pichler @mrekucci @acud @istae