Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bucket depth size expectation #2099

Merged
merged 2 commits into from
Jun 16, 2021
Merged

fix: bucket depth size expectation #2099

merged 2 commits into from
Jun 16, 2021

Conversation

anatollupacescu
Copy link
Contributor

@anatollupacescu anatollupacescu commented Jun 15, 2021

Fixing the precondition to be aligned with contract check:

https://github.com/ethersphere/storage-incentives/blob/master/src/PostageStamp.sol#L100

This change is Reviewable

@anatollupacescu anatollupacescu marked this pull request as draft June 15, 2021 15:37
Copy link
Member

@zelig zelig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @anatollupacescu)

Copy link
Contributor

@Eknir Eknir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Eknir Eknir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the test

Copy link
Contributor

@Eknir Eknir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you for updating the tests!

@anatollupacescu anatollupacescu marked this pull request as ready for review June 16, 2021 11:19
@anatollupacescu anatollupacescu added the ready for review The PR is ready to be reviewed label Jun 16, 2021
Copy link
Contributor

@Eknir Eknir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @anatollupacescu)

@anatollupacescu anatollupacescu merged commit 5d5bdaf into master Jun 16, 2021
@anatollupacescu anatollupacescu deleted the fix-batch-check branch June 16, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants