Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set explicit gas limits #2101

Merged
merged 1 commit into from
Jun 16, 2021
Merged

fix: set explicit gas limits #2101

merged 1 commit into from
Jun 16, 2021

Conversation

ralph-pichler
Copy link
Member

@ralph-pichler ralph-pichler commented Jun 15, 2021

set explicit gas limits to work around nethermind issues.

This change is Reviewable

@ralph-pichler ralph-pichler self-assigned this Jun 15, 2021
@ralph-pichler ralph-pichler added the ready for review The PR is ready to be reviewed label Jun 15, 2021
Copy link
Member

@zelig zelig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ralph-pichler)


pkg/postage/postagecontract/contract.go, line 75 at r1 (raw file):

		Data:     callData,
		GasPrice: sctx.GetGasPrice(ctx),
		GasLimit: 65000,

should this not depend on the chain you use?

Copy link
Member

@zelig zelig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ralph-pichler)


pkg/postage/postagecontract/contract.go, line 75 at r1 (raw file):

Previously, zelig (Viktor Trón) wrote…

should this not depend on the chain you use?

same for all values.

Copy link
Member Author

@ralph-pichler ralph-pichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @zelig)


pkg/postage/postagecontract/contract.go, line 75 at r1 (raw file):

Previously, zelig (Viktor Trón) wrote…

same for all values.

no, the gas usage should be similar on any chain (provided the evm version is the same which seems a reasonable assumption). the primary potential issue is a future hardfork with big gas changes, but there is nothing we can do about that now (except using the estimator which we cannot do on xdai/nethermind).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants