-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow separate accounting store #2109
Conversation
6eb6f11
to
f91efac
Compare
Why would you want to do this? |
@Eknir so you can reset statestore / localstore without resettting private key / chequebooks. |
that's useful 👍 |
But isn't the checkbook address stored in statestore? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ralph-pichler)
pkg/node/statestore.go, line 40 at r1 (raw file):
return ret, nil } return leveldb.NewStateStore(filepath.Join(dataDir, "accountingstore"), log)
Would be nice to check the dataDir
validity before passing it, e.g.:
dir, err := os.Stat(dataDir)
if err != nil {
return fmt.Errorf("failed to open directory, error: %w", err)
}
if !dir.IsDir() {
return fmt.Errorf("%q is not a directory", dir.Name())
}
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This PR was closed because it has been stalled for 5 days with no activity. |
related to #968
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)