refactor(pushsync): better tracing #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
force-pushed
the
pushsync-spans
branch
from
809d6c9
to
5942a25
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
janos
approved these changes
Sep 17, 2021
| // decouple the span data from the original context so it doesn't get | ||
| // cancelled, then glue the stuff on the new context | ||
| span := tracing.FromContext(ctx) | ||
|
|
||
| ctx, cancel := context.WithTimeout(context.Background(), timeToWaitForPushsyncToNeighbor) |
There was a problem hiding this comment.
Since ctx is now passed to pushToNeighbour, could here context.Background() be replaced with ctx?
There was a problem hiding this comment.
I'm passing it just so I can extract the OT span info out of it. The reason we're using context.Background is so that the parent context doesn't expire while we do the replication
mrekucci
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds traces for replication (on the origin and target nodes) and moves the handler span creation to the right place
This change is